fix file:close signature #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since Lua 5.2, when closing a file handle created with io.popen, file:close returns the same values returned by os.execute.
|
Teal Playground URL: https://687--teal-playground-preview.netlify.app |
|
It would be good to get this merged and released when merging this here!... I just sent a ping over there. If I get no response I'll go ahead and merge both. |
|
I got no response regarding compat53 from @siffiejoe, so I went ahead and moved the LuaRocks entry to the lunarmodules org (of which we're both members on GitHub), and then released the update which includes the change needed by this PR. |
hishamhm
added a commit
that referenced
this pull request
Oct 19, 2023
hishamhm
added a commit
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since Lua 5.2, when closing a file handle created with
io.popen,file:closereturns the same values returned byos.execute.